Commit eb2074a1 authored by Chris Michael's avatar Chris Michael Committed by Kristian H. Kristensen

Fix not checking return value of drmIoctl function call to map dumb buffer

in drm_fb_create_dumb, the return value of the drmIoctl function call
to map the dumb buffer was never checked, thus the following "if
(ret)" check was invalid as it was checking the previous return value
from the above drmModeAddFB call.
Signed-off-by: default avatarChris Michael <>
parent ab745623
......@@ -268,8 +268,7 @@ drm_fb_create_dumb(struct drm_compositor *ec, unsigned width, unsigned height)
memset(&map_arg, 0, sizeof(map_arg));
map_arg.handle = fb->handle;
drmIoctl(fb->fd, DRM_IOCTL_MODE_MAP_DUMB, &map_arg);
ret = drmIoctl(fb->fd, DRM_IOCTL_MODE_MAP_DUMB, &map_arg);
if (ret)
goto err_add_fb;
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment