Hi @pzanoni
After your commit 89a34cb8, there was a flickering bug in several applications. Mostly who use WebGL. This bug is related to the EXEC_OBJECT_ASYNC flag:
if (!iris_bo_is_external(bo))
extra_flags |= EXEC_OBJECT_ASYNC;
According to the description: "The kernel maintains the implicit tracking in order to manage resources used by the GPU - this flag only disables the synchronisation prior to rendering with this object in this execbuf.
Opting out of implicit synhronisation requires the user to do its own explicit tracking to avoid rendering corruption. See, for example, I915_PARAM_HAS_EXEC_FENCE to order execbufs and execute them asynchronously."
I suggest that either the applications need to change their code or remove the addition of this flag.
Can you please tell me if the addition of this flag affects something else or can it be removed?
I found a place in the code that was not working correctly. I will try to fix it.
I know about it. There are several issues about this bug.
I found a place in the code that was not working correctly. I will try to fix it.
Hi @idr ,
I am unable to repeat this bug on the current version of Mesa, please check it on your configuration.
Hi @nchery!
Please, check this test.
Hi @idr ,
I was unable to replicate this effect on Comet Lake with Iris. And according to many reviews on the Steam game forum, many players have problems with brightness on different platforms. Also on the forum there is a solution to this problem with brightness: in the files "steam/steamapps/common/Left 4 Dead 2/left4dead2/cfg/video.txt" and "steam/steamapps/common/Left 4 Dead 2/left4dead2/cfg/videodefaults.txt" add the line:
"setting.mat_tonemapping_occlusion_use_stencil" "1"
This should fix the brightness issue. Could you check this solution to the problem on Ice Lake with Iris?
Hi @nchery!
Please, check this test.
Fix defect reported by Coverity Scan.
Missing lock and unlock (LOCK). Set queue->submit.thread_run without lock and unlock.
Signed-off-by: Sergii Melikhov sergii.v.melikhov@globallogic.com
Sergii Melikhov (8bdb0e7f) at 25 Nov 12:04
mesa: Check the return value.
Sergii Melikhov (8bdb0e7f) at 25 Nov 11:56
mesa: Check the return value.
Sergii Melikhov (2cf36a0b) at 24 Nov 11:27
vulkan: Unlock before return.
Sergii Melikhov (f5af71db) at 24 Nov 10:08
vulkan: Unlock before return.
Sergii Melikhov (2fea78d5) at 23 Nov 18:17
vulkan: Unlock before return.
Sergii Melikhov (0dbef6e2) at 23 Nov 18:13
vulkan: Set queue->submit.thread_run with lock and unlock.
Sergii Melikhov (a621809b) at 23 Nov 18:02
vulkan: Set queue->submit.thread_run without lock and unlock.