Skip to content
  • Keith Packard's avatar
    glamor: Preserve GL_RED bits in R channel when destination is GL_RED [v2] · 181a4bd0
    Keith Packard authored
    A1 and A8 pixmaps are usually stored in the Red channel to conform
    with more recent GL versions. When using these pixmaps as mask values,
    that works great. When using these pixmaps as source values, then the
    value we want depends on what the destination looks like.
    
    For RGBA or RGB destinations, then we want to use the Red channel
    for A values and leave RGB all set to zero.
    
    For A destinations, then we want to leave the R values in the Red
    channel so that they end up in the Red channel of the output.
    
    This patch adds a helper function, glamor_bind_texture, which performs
    the glBindTexture call along with setting the swizzle parameter
    correctly for the Red channel. The swizzle parameter for the Alpha
    channel doesn't depend on the destination as it's safe to leave it
    always swizzled from the Red channel.
    
    This fixes incorrect rendering in firefox for this page:
    
    	https://gfycat.com/HoarseCheapAmericankestrel
    
    while not breaking rendering for this page:
    
    	https://feedly.com
    
    v2: Add change accidentally left in patch for missing
        glDisable(GL_COLOR_LOGIC_OP).
        Found by Emil Velikov <emil.l.velikov@gmail.com>
    
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=63397
    
    
    Signed-off-by: default avatarKeith Packard <keithp@keithp.com>
    Tested-by: default avatarMichel Dänzer <michel.daenzer@amd.com>
    181a4bd0